Emit metrics via otel instead of custom format #4762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
reviewed
Jan 31, 2025
ramonsmits
reviewed
Jan 31, 2025
ramonsmits
reviewed
Jan 31, 2025
andreasohlund
force-pushed
the
otel-metrics
branch
from
b986142 to
14c3474
Compare
Member
Author
|
@lailabougria can you spot anything off in terms of how we emit the telemetry? naming etc |
ramonsmits
reviewed
Feb 3, 2025
ramonsmits
previously requested changes
Feb 3, 2025
ramonsmits
reviewed
Feb 3, 2025
ramonsmits
reviewed
Feb 3, 2025
ramonsmits
reviewed
Feb 5, 2025
Member
Author
|
@lailabougria ready for review |
ramonsmits
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the homegrown metrics in the audit instance with OTEL to allow for easier consumption in visualization tools like Prometheus, Azure Monitor etc